Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't fail on empty bodies when sending out read receipts #10531

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Don't fail on empty bodies when sending out read receipts #10531

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ad3563
Don't fail on empty bodies when sending out read receipts
babolivier Aug 4, 2021
edfede6
Changelog
babolivier Aug 4, 2021
85023d9
Add test
babolivier Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/10531.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in Synapse v1.40.0rc1 that would cause Synapse to respond with an error when clients would update their read receipts.
2 changes: 1 addition & 1 deletion synapse/rest/client/v2_alpha/receipts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ async def on_POST(self, request, room_id, receipt_type, event_id):
if receipt_type != "m.read":
raise SynapseError(400, "Receipt type must be 'm.read'")

body = parse_json_object_from_request(request)
body = parse_json_object_from_request(request, allow_empty_body=True)
hidden = body.get(ReadReceiptEventFields.MSC2285_HIDDEN, False)

if not isinstance(hidden, bool):
Expand Down