Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix iteration in _remove_deleted_email_pushers background job. #10734

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Fix iteration in _remove_deleted_email_pushers background job. #10734

merged 4 commits into from
Sep 1, 2021

Commits on Sep 1, 2021

  1. Fix iteration over row results 

    We were originally iterating over 'txn', which can work, but as 'txn' was being used to run a
simple_delete operation inside the loop, it was actually being redefined mid-loop.

Thus, this caused the background job that was intended to remove old pushers that were
associated with an unlinked email address to fail if there were any to remove.
    @anoadragon453
    anoadragon453 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    ec767e2 View commit details
    Browse the repository at this point in the history

  2. Add a test that runs the background job with an unlinked pusher

    @anoadragon453
    anoadragon453 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    e219d4b View commit details
    Browse the repository at this point in the history

  3. Changelog

    @anoadragon453
    anoadragon453 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    ec1bccb View commit details
    Browse the repository at this point in the history

  4. self.hs -> hs

    @anoadragon453
    anoadragon453 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    b1ee216 View commit details
    Browse the repository at this point in the history