Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix race in MultiWriterIdGenerator #11045

Merged
merged 7 commits into from
Oct 12, 2021
Merged

Fix race in MultiWriterIdGenerator #11045

merged 7 commits into from
Oct 12, 2021

Commits on Oct 11, 2021

  1. Move adding stream ids to unfinished dict

    @erikjohnston
    erikjohnston committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    a63b6f4 View commit details
    Browse the repository at this point in the history

  2. Track max seen allocated stream ID

    @erikjohnston
    erikjohnston committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    a0d1cce View commit details
    Browse the repository at this point in the history

  3. Fix race in MultiWriterIdGenerator 

    The race allowed the current position to advance too far when stream IDs
are still being persisted.

This happened when it received a new stream ID from a remote write
between a new stream ID being allocated and it being added to the set of
unpersisted stream IDs.

Fixes #9424.
    @erikjohnston
    erikjohnston committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    7166060 View commit details
    Browse the repository at this point in the history

  4. Newsfile

    @erikjohnston
    erikjohnston committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    9c055f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Sean Quah <[email protected]>
    @erikjohnston @squahtx
    erikjohnston and squahtx authored Oct 12, 2021
    Configuration menu
    Copy the full SHA
    7381bcc View commit details
    Browse the repository at this point in the history

  2. Handle _in_flight_fetches same way as _unfinished_ids

    @erikjohnston
    erikjohnston committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    46369bf View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @erikjohnston
    erikjohnston committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    20f877d View commit details
    Browse the repository at this point in the history