Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't create empty AS txns when the AS is down #12869

Merged
merged 2 commits into from
May 25, 2022
Merged

Don't create empty AS txns when the AS is down #12869

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8595122
Don't create empty AS txns when the AS is down
Fizzadar Apr 25, 2022
9425bc2
Add changelog file
Fizzadar May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion synapse/appservice/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,11 @@ async def send(
device_list_summary: The device list summary to include in the transaction.
"""
try:
service_is_up = await self._is_service_up(service)
# Don't create empty txns when in recovery mode (ephemeral events are dropped)
if not service_is_up and not events:
return

txn = await self.store.create_appservice_txn(
service=service,
events=events,
Expand All @@ -393,7 +398,6 @@ async def send(
unused_fallback_keys=unused_fallback_keys or {},
device_list_summary=device_list_summary or DeviceListUpdates(),
)
service_is_up = await self._is_service_up(service)
if service_is_up:
sent = await txn.send(self.as_api)
if sent:
Expand Down