This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix a bug where the joined hosts for a given event were not being properly cached #14125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we pre-calculate the joined hosts at an event when using redis so that external federation senders don't have to calculate this themselves. The bug being fixed, introduced in #13800, resulted in the joined hosts only being calculated for the first event in a batch being persisted, rather than at all of them. This PR changes
cache_joined_hosts_for_eventsto take a list of events, and calculate the joined hosts at each of the events.