This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was #14516 some prerequisite work for this change (or at least to see a performance difference with the combination)?
From a glance, it seems #14516 changed the lookup to use
(stream_id, room_id)
and this PR adds an index for thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was a combination really, but hard to know. The main aim of #14516 was to make it so that the rows of
device_lists_changes_in_room
on disk were roughly ordered by stream ID, making it much more efficient to look at rows in stream ID order.This PR mainly speeds up queries that were being done during sync, around "has anything changed since X in a particular set of rooms R"