Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Tweak comment on _is_local_room_accessible as part of room visibility in /hierarchy to clarify the condition for a room being visible. #14834

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Tweak comment on _is_local_room_accessible as part of room visibility in /hierarchy to clarify the condition for a room being visible. #14834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a9c454
Tweak doc for space room visibility
reivilibre Jan 13, 2023
0d5426a
Newsfile
reivilibre Jan 13, 2023
d943a51
CI kick :/
reivilibre Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/14834.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Tweak comment on `_is_local_room_accessible` as part of room visibility in `/hierarchy` to clarify the condition for a room being visible.
4 changes: 2 additions & 2 deletions synapse/handlers/room_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,8 +521,8 @@ async def _is_local_room_accessible(

It should return true if:

* The requester is joined or can join the room (per MSC3173).
* The origin server has any user that is joined or can join the room.
* The requesting user is joined or can join the room (per MSC3173); or
* The origin server has any user that is joined or can join the room; or
* The history visibility is set to world readable.

Args:
Expand Down