Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix upgrading a room without events field in power levels #16725

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Dec 4, 2023

Fixes #16715, per #16715 (comment). Looks to have been introduced in #6237.

C.f. https://spec.matrix.org/v1.9/client-server-api/#mroompower_levels

Sanity checking Erik's reasoning, the point of this code is to ensure that the upgrader is able to set any state in the new room. If event_power_levels is empty then there are no extra requirements to impose, so I think a fallback of 0 is sensible.

@DMRobertson DMRobertson marked this pull request as ready for review December 4, 2023 16:17
@DMRobertson DMRobertson requested a review from a team as a code owner December 4, 2023 16:17
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@DMRobertson
Copy link
Contributor Author

Tests are very unhappy

@DMRobertson DMRobertson merged commit 0a00c99 into develop Dec 5, 2023
39 of 41 checks passed
@DMRobertson DMRobertson deleted the dmr/upgrade-room branch December 5, 2023 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Internal server error" when upgrading a room created with Conduit
2 participants