This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix code for reporting old verify keys in synapse #2156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for generating the
"old_verify_keys"
section in local_key_resource was buggy.It was assuming that the
old_signing_keys
was a list when in fact it was a dict.The net result was that any server that tried to fill out the
"old_signing_keys"
config entry would crash on startup as it tried to pre-generate the local key response.