Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Modify register/available to be GET with query param #2213

Merged
merged 2 commits into from
May 11, 2017
Merged

Modify register/available to be GET with query param #2213

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
369195c
Modify register/available to be GET with query param
May 10, 2017
ccad2ed
Modify condition on empty localpart
May 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions synapse/handlers/register.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ def check_username(self, localpart, guest_access_token=None,
Codes.INVALID_USERNAME
)

if len(localpart) == 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally one would just do if not localpart

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair!

raise SynapseError(
400,
"User ID cannot be empty",
Codes.INVALID_USERNAME
)

if localpart[0] == '_':
raise SynapseError(
400,
Expand Down
9 changes: 4 additions & 5 deletions synapse/rest/client/v2_alpha/register.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from synapse.api.constants import LoginType
from synapse.api.errors import SynapseError, Codes, UnrecognizedRequestError
from synapse.http.servlet import (
RestServlet, parse_json_object_from_request, assert_params_in_request
RestServlet, parse_json_object_from_request, assert_params_in_request, parse_string
)
from synapse.util.msisdn import phone_number_to_msisdn

Expand Down Expand Up @@ -142,15 +142,14 @@ def __init__(self, hs):
)

@defer.inlineCallbacks
def on_POST(self, request):
def on_GET(self, request):
ip = self.hs.get_ip_from_request(request)
with self.ratelimiter.ratelimit(ip) as wait_deferred:
yield wait_deferred

body = parse_json_object_from_request(request)
assert_params_in_request(body, ['username'])
username = parse_string(request, "username", required=True)

yield self.registration_handler.check_username(body['username'])
yield self.registration_handler.check_username(username)

defer.returnValue((200, {"available": True}))

Expand Down