This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian package builds were failing for two reasons:
Python versions prior to 3.7 throw exceptions when attempting to print Unicode characters under a "C" locale.
We depended on
dh-systemd
which no longer exists in Debian Bullseye, but is necessary in Ubuntu Xenial.Fixing the first issue is as easy as setting
LANG="C.UTF-8"
in the build environment. (See https://bugs.python.org/issue19846)Fixing the second issue requires attempting to install
dh-systemd
, but ignoring failures when it does not exist.Specifically, the
dh-systemd
package was merged with the maindebhelper
package as of debhelper (>= 9.20160709)` and a transitional package was left in its place.That transitional package was removed in Debian Bullseye after being present in both Stretch and Buster. Thus, on the Debian side, just removing the dependency on
dh-systemd
would be sufficient.However, Ubuntu Xenial has an old
debhelper
version, and thus actually needsdh-systemd
. So we still try to install it on all distros, but ignore when that fails.Once we drop support for Xenial (March 2021?) we can completely remove anything referencing
dh-systemd
.Fixes #9073
Fixes #9076