This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Unpin attrs dep after new version has been released #9946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babolivier
approved these changes
May 7, 2021
Yeah probably, I'll make a release-v1.33.2 branch and we can merge it in there? |
sgtm |
callahad
reviewed
May 7, 2021
| @@ -79,7 +79,7 @@ | |||
| # Fedora 31 only has 19.1, so if we want to upgrade we should wait until 33 | |||
| # is out in November.) | |||
| # Note: 21.1.0 broke `/sync`, see #9936 | |||
| "attrs>=19.1.0,<21.1.0", | |||
| "attrs>=19.1.0,!=21.1.0", | |||
There was a problem hiding this comment.
Probably unnecessary; 21.1.0 was yanked from PyPI, so it effectively no longer exists. We can go back to just attrs>=19.1.0
There was a problem hiding this comment.
Mmm, true. Though I think since we know its bad we may as well leave it in there. I'm not sure if e.g. pypi mirrors and the like handle yanking etc.
babolivier
added a commit
to matrix-org/synapse-dinsic
that referenced
this pull request
Sep 1, 2021
Synapse 1.33.2 (2021-05-11) =========================== Due to the security issue highlighted below, server administrators are encouraged to update Synapse. We are not aware of these vulnerabilities being exploited in the wild. Security advisory ----------------- This release fixes a denial of service attack ([CVE-2021-29471](GHSA-x345-32rc-8h85)) against Synapse's push rules implementation. Server admins are encouraged to upgrade. Internal Changes ---------------- - Unpin attrs dependency. ([\#9946](matrix-org/synapse#9946))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attrs 21.2.0 has been released with the fix to
evolve.c.f. #9936