fix: Use a constant-time Base64 encoder for secret key material #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a security issue around a side-channel vulnerability[1] when decoding secret key material using Base64. In some circumstances an attacker can obtain information about secret secret key material via a controlled-channel and side-channel attack. This patch avoids the side-channel by switching to the base64ct crate for the encoding, and more importantly, the decoding of secret key material. [1]: https://arxiv.org/abs/2108.04600
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 90.56% 90.57%
=======================================
Files 34 34
Lines 1908 1910 +2
=======================================
+ Hits 1728 1730 +2
Misses 180 180 ☔ View full report in Codecov by Sentry. |
dkasak
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a security issue around a side-channel vulnerability1 when decoding secret key material using Base64.
In some circumstances an attacker can obtain information about secret key material via a controlled-channel and side-channel attack.
This patch avoids the side-channel by switching to the base64ct crate for the encoding, and more importantly, the decoding of secret key material.
Footnotes
https://arxiv.org/abs/2108.04600 ↩