Fix username dedup for synthetic users #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enahum I don't mind dealing with the conflict if you wanna merge your branch first! I don't think this is super urgent: we would need at least three users with the exact same username for this to happen, and this is not anything that would put the plugin in a broken state. |
JulienTant
added
2: Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When creating a new synthetic user, the synthetic user is being given a username of
msteams_[username]. If this is not available, we want to suffix this with-{idx}. The current code would add-{idx}at the end of each iteration, leading to the username looking likemsteams_[username]-1-2-3-4instead ofmsteams_[username]-4.This PR fixes this issue.
Ticket Link
N/A