avoid crash #37
Open
avoid crash #37
+0
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nakajijapan
reviewed
Oct 29, 2017
| gifGroup.enter() | ||
|
|
||
| generator.generateCGImagesAsynchronously(forTimes: times, completionHandler: { (requestedTime, image, actualTime, result, error) in | ||
| guard let imageRef = image , error == nil else { | ||
| print("An error occurred: \(error), image is \(image)") | ||
| dispatchError = true | ||
| gifGroup.leave() |
There was a problem hiding this comment.
I think that gifGroup.leave()'s position isn't good. In this case, leave is called only if an error doesn't occur. We should call leave every cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when an error occur the giftGroup will been leaved, but the loop will continue. Finally at the last time the code will be execute giftGroup.leave() this will crash