Skip to content

Commit

Permalink
fix: Fixed race condition in action server between is_ready and take"… (
Browse files Browse the repository at this point in the history
ros2#2531)

* fix: Fixed race condition in action server between is_ready and take" (ros2#2495)

Some background information: is_ready, take_data and execute data
may be called from different threads in any order. The code in the old
state expected them to be called in series, without interruption.
This lead to multiple race conditions, as the state of the pimpl objects
was altered by the three functions in a non thread safe way.

Co-authored-by: William Woodall <[email protected]>
Signed-off-by: Janosch Machowinski <[email protected]>

* fix: added workaround for call to double calls to take_data

This adds a workaround for a known bug in the executor in iron.

Signed-off-by: Janosch Machowinski <[email protected]>

---------

Signed-off-by: Janosch Machowinski <[email protected]>
Co-authored-by: Janosch Machowinski <[email protected]>
Co-authored-by: William Woodall <[email protected]>
  • Loading branch information
3 people authored and Mauro Passerino committed Aug 9, 2024
1 parent 25fac83 commit f165a25
Show file tree
Hide file tree
Showing 2 changed files with 566 additions and 243 deletions.
Loading

0 comments on commit f165a25

Please sign in to comment.