fix: add support for angular 8 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this Matt! I was gonna try, but I couldn't find the time. Do we need to update the peer dependencies in /ngx-clipboard for the project to include Angular 8? |
|
It should be fine, |
|
@mattlewis92 Could you test it? [email protected] Thanks for your help! |
|
Works for me! 😄 |
|
it is on 12.0.1 now Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, thanks for your work on this library! 😄 This PR migrates the import to be from common instead, it's been there since v6 which is the minimum version this lib supports, so it shouldn't be a breaking change.
Fixes #178