This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Added accessors to the list of all country names and codes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should return the underlying array, as it would allow someone to modify them. Perhaps returning a new list would be better. |
Also return a `List<String>` rather than an array for convenience.
|
Fair enough, here's a new version. |
oschwald
added a commit
that referenced
this pull request
Feb 8, 2016
Added accessors to the list of all country names and codes
|
Thanks! I released 1.3.1 with these changes. |
|
That's great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be generally useful, in my specific case my application needs to be able to "match" a country name selected by a user with the country name detected by GeoIP. Without access to the list of countries I would have to manually maintain the list separately with the risk of it getting out of sync.