-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinFraudClientInterface? #165
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current MinFraud implementation is very hard to test (in our test suites with PHPUnit). We are forced to create a class that inherits from
MaxMind\MinFraud
but disables the constructor.It would be very helpful if some
MinFraudClientInterface
could be created thus makingMaxMind\MinFraud
implement it. We could then use this in our tests to easily create a mock object.The text was updated successfully, but these errors were encountered: