Risk score reasons #180
Merged
Risk score reasons #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marselester
force-pushed
the
risk-reasons-beta
branch
12 times, most recently
from
54c1cef
to
7556bb3
Compare
ugexe
requested changes
Aug 30, 2024
marselester
force-pushed
the
risk-reasons-beta
branch
from
7556bb3
to
6389829
Compare
ugexe
requested changes
Sep 3, 2024
src/MinFraud/Model/Reason.php
Outdated
| /** | ||
| * @var string This value is a machine-readable code identifying the reason | ||
| */ | ||
| public readonly ?string $code; |
There was a problem hiding this comment.
Doesn't ?string suggests the description should be @var string|null? Alternatively maybe this should be string instead of ?string (which would also simplify this file by not needing the !== null checks)
There was a problem hiding this comment.
Good point, updated.
marselester
force-pushed
the
risk-reasons-beta
branch
from
6389829
to
7ca7302
Compare
ugexe
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.