Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delayMicrosoconds() is not accurate on some platforms #508

Closed
terrillmoore opened this issue Dec 30, 2019 · 1 comment
Closed

delayMicrosoconds() is not accurate on some platforms #508

terrillmoore opened this issue Dec 30, 2019 · 1 comment
Assignees
@terrillmoore
Labels
bug

Comments

@terrillmoore
Copy link
Member

hal_waitUntil() is relied upon to wait until the time has certainly been reached. But it doesn't check, it just depends on delayMicroseconds()... which isn't accurate at least on MCCI's STM32 BSP. This is not a super-useful optimization; better to just use delta_time() and loop. A little more quantization noise, but much better to be a little late than way early.
@terrillmoore terrillmoore self-assigned this Dec 30, 2019
@terrillmoore
Copy link
Member Author

This was a big contributor to the problems seen in #442.

@terrillmoore terrillmoore mentioned this issue Dec 30, 2019
Merged
bertrik added a commit to bertrik/arduino-lmic that referenced this issue Jan 29, 2020
@bertrik
Revert "Fix mcci-catena#508: don't depend on delayMicroseconds()"
6d6c26a 
This reverts commit 306330f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore