forked from things-nyc/arduino-lmic
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code gives: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #606
Labels
Comments
Yep, that's a problem; too clever by half. I'll look at this as part of the secure element (#578) refactoring merge that's coming up. I'm still in the six months of horribly busy with the day job phase of my life that corresponded with the pandemic; I'm beginning to see daylight but... |
Ok! No hurry, it's just goldplating :-) |
terrillmoore
added a commit
that referenced
this issue
Feb 23, 2021
terrillmoore
added a commit
that referenced
this issue
Feb 23, 2021
terrillmoore
added a commit
that referenced
this issue
Feb 23, 2021
Fix #606: don't use defined() in macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When compiling the ttn-otaa example with the current git master, and warnings enabled in the IDE, I get a ton of warnings like this one:
I think this warning was added in a recent compiler upgrade.
This comes from this macro definition:
which, when used in an
#if
, gives non-portable behavior. It is easy to fix, though, I think something like this should be equivalent but without the warning:(haven't tested, though).
Similar warnings (with I presume similar fixes) happen for e.g.
CFG_LMIC_EU_like
and friends.Environment
To Reproduce
Compile the ttn-otaa example with warnings enabled in the IDE preferences
The text was updated successfully, but these errors were encountered: