Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX EIRP is 13dBm (= 19.95mW < 20mW) in as923jp #662

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

ryos36
Copy link

@ryos36 ryos36 commented Jan 17, 2021

16dBm is used as MAX EIRP when using OTAA in as923. However MAX EIRP is 13dBm in as923jp.

Copy link
Member

@terrillmoore terrillmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. Happy to accept with changes along the line I suggest.

@@ -3,7 +3,7 @@
#define CFG_us915 1
//#define CFG_au915 1
//#define CFG_as923 1
// #define LMIC_COUNTRY_CODE LMIC_COUNTRY_CODE_JP /* for as923-JP */
//#define CFG_as923jp 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

I don't understand this part of change. The code on line 6 is the correct way to handle this (and in fact lmic_confgi_preconditions.h expands the shorthand). We avoid #ifdef as much as possible in the code; the config system converts #ifdef to equivalent symbols that are always either 1 or 0.

@@ -68,7 +68,11 @@ enum {
AS923_FREQ_MAX = 928000000
};
enum {
#if defined(CFG_as923jp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, this line should be #if LMIC_COUNTRY_CODE == LMIC_COUNTRY_CODE_JP.

terrillmoore added a commit that referenced this pull request Oct 10, 2021
@terrillmoore terrillmoore merged commit b6df2d4 into mcci-catena:master Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants