Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fix from #19 to 1.x #20

Merged
merged 1 commit into from
May 25, 2019
Merged

Backport fix from #19 to 1.x #20

merged 1 commit into from
May 25, 2019

Conversation

phated
Copy link

@phated phated commented May 25, 2019

@mcollina here's the backport to 1.x - I submitted it against master but it's probably best to just pull into a branch.

I used pump to replace stream.pipeline in the tests and used from2 because the destroy stuff was weird in the old ReadableStream.

Thanks for accepting this backport! 🍻

@mcollina mcollina changed the base branch from master to v1.x May 25, 2019 17:22
@mcollina mcollina merged commit c2bdd8d into mcollina:v1.x May 25, 2019
@mcollina
Copy link
Owner

Released as v1.1.3!

@phated
Copy link
Author

phated commented May 26, 2019

Thanks @mcollina! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phated @mcollina