boot: zephyr: Allow disabling NRFX_WDT on nRF devices #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
reviewed
Sep 24, 2024
Allow disabling feeding the watchdog on nrf devices directly using the nrfx_wdt functions. The imply on NRFX_WDT cannot be disabled since NRFX_WDT is a promptless symbol and cannot be assigned in a config fragment. Not even deleting the wdt0 node in a devicetree overlay works since the configuration takes predence and ends in a #error without any nrfx_wdt instances. To fix this create new Kconfig option with prompt and change the imply to this option. That way the option can be assigned to off by the user. This is needed to support the use case of an external watchdog controlled using the zephyr watchdog API instead of the wdt peripheral. Signed-off-by: Joakim Andersson <[email protected]>
joerchan
force-pushed
the
allow-external-watchdog
branch
from
03cf0dd
to
635cffc
Compare
nordicjm
approved these changes
Sep 24, 2024
de-nordic
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow disabling feeding the watchdog on nrf devices directly using the nrfx_wdt functions.
The imply on NRFX_WDT cannot be disabled since NRFX_WDT is a promptless symbol and cannot be assigned in a config fragment. Not even deleting the wdt0 node in a devicetree overlay works since the configuration takes predence and ends in a #error without any nrfx_wdt instances.
To fix this create new Kconfig option with prompt and change the imply to this option. That way the option can be assigned to off by the user.
This is needed to support the use case of an external watchdog controlled using the zephyr watchdog API instead of the wdt peripheral.