Intl resolved options order correction, normalize description #36056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:JS
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
files/en-us/web/javascript/reference/global_objects/intl/numberformat/resolvedoptions/index.md
Outdated
Show resolved
Hide resolved
|
Thanks! It has always been on my TODOs to fix the Intl options and reordering them was one of the goals. Will check this soon. |
…'s `resolvedOptions()` to match 402 spec
…layNames` objects
…tFormat's `resolvedOptions()` to match 402 spec
ben-allen
force-pushed
the
intl-resolved-options-order-correction
branch
from
20f748d
to
95ab21e
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
…'s `resolvedOptions()` to match 402 spec
…tFormat's `resolvedOptions()` to match 402 spec
ben-allen
force-pushed
the
intl-resolved-options-order-correction
branch
from
1434af4
to
c874c7d
Compare
|
rebased! |
…tions-order-correction' into intl-resolved-options-order-correction
Josh-Cena
changed the title
Josh-Cena
approved these changes
Sep 27, 2024
Closed
3 tasks
|
Thank you so much! |
fiji-flo
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Added `"languageDisplay"` to `resolvedOptions()` of `Intl.DisplayNames` objects * Swapped order of `"style"` and `"type"` properties in Intl.ListFormat's `resolvedOptions()` to match 402 spec * Reordered `Intl.NumberFormat` `resolvedOptions` to reflect spec order. * Reordered `resolvedOptions` properties for `Intl.PluralRules` to reflect spec order * fixup! Added `"languageDisplay"` to `resolvedOptions()` of `Intl.DisplayNames` objects * fixup! Swapped order of `"style"` and `"type"` properties in Intl.ListFormat's `resolvedOptions()` to match 402 spec * Standardize format, first three * Fixes * Swapped order of `"style"` and `"type"` properties in Intl.ListFormat's `resolvedOptions()` to match 402 spec * Reordered `Intl.NumberFormat` `resolvedOptions` to reflect spec order. * Reordered `resolvedOptions` properties for `Intl.PluralRules` to reflect spec order * fixup! Swapped order of `"style"` and `"type"` properties in Intl.ListFormat's `resolvedOptions()` to match 402 spec * Fix others * numberformat --------- Co-authored-by: Joshua Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorders the
resolvedOptionsofIntlobjects to the order in which properties are added in the spec. Adds a few properties that were previously left offresolvedOptionsreturn value.Motivation
Improve readability/consistency of
Intldocumentation.Additional details
See discussion here: #33340
Related issues and pull requests
Fixes #36055