Update html5-qrcode-scanner.ts #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add attribute type with value button to button-tags, so Firefox will not do a submit
mebjas
reviewed
Feb 26, 2022
README.md
Outdated
| @@ -1,856 +1,4 @@ | |||
| # Html5-QRCode | |||
| ## (supports barcodes now :)) | |||
| A cross-platform HTML5 QR code & barcode reader. | |||
| Fork for pull request for mebjas/html5-qrcode | |||
| @@ -492,6 +492,7 @@ export class Html5QrcodeScanner { | |||
| requestPermissionContainer: HTMLDivElement) { | |||
| const $this = this; | |||
| const requestPermissionButton = document.createElement("button"); | |||
| requestPermissionButton.setAttribute("type", "button"); | |||
| @@ -640,11 +641,13 @@ export class Html5QrcodeScanner { | |||
|
|
|||
| const cameraActionContainer = document.createElement("span"); | |||
| const cameraActionStartButton = document.createElement("button"); | |||
| cameraActionStartButton.setAttribute("type", "button"); | |||
There was a problem hiding this comment.
How about we define a method
private createButton(): HtmlButtonElement {
let button = document.createElement("button");
button.setAttribute("type", "button");
return button;
}And use it in all these places?
There was a problem hiding this comment.
Yes, that would be a nice solution to get every button at the same implementation state.
|
Thanks for the PR, please take a look at the review comments. |
|
Hi @Joggel72 - Please revert back the readme and then we can submit. |
I hope I've made it correct by deleting the file. |
Merged
|
Thanks for the PR, the PR is fairly outdated. Will send another PR with your commit (you as author) - #588 Appreciate the contribution. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add attribute type with value button to button-tags, so Firefox will not do a submit as discussed in comment #413 (comment)