Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix qrbox border placement #555

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Fix qrbox border placement #555

merged 2 commits into from
Oct 24, 2022

Commits on Oct 13, 2022

  1. Add display: block; to the video element 

    A video element behave like an inline element, which mean it honours
whitespace around. When in a div with whitespace it adds empty spaces.

ref: https://stackoverflow.com/a/36397260
    @allanbrault
    allanbrault committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    a044e6e View commit details
    Browse the repository at this point in the history

  2. Update logic to display the qrbox border elements 

    Using the bottom allow the 4 boxes on the bottom of the qrbox to be
pixel perfect on the bottom of the qrbox area, instead of relying on the
qrbox size that can be with a floating point.
    @allanbrault
    allanbrault committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    cf7546d View commit details
    Browse the repository at this point in the history