chore: safe catch by verifying the appropriate error

medusajs · Dec 7, 2022 · 426d8c6 · 426d8c6
1 parent 110225c
commit 426d8c6
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/packages/medusa/src/services/cart.ts b/packages/medusa/src/services/cart.ts
@@ -665,7 +665,12 @@ class CartService extends TransactionBaseService {
  { cart_id: cartId, has_shipping: true },
  { has_shipping: false }
  )
- .catch(() => void 0)
+ .catch((err: Error) => {
+ // We only want to catch the errors related to not found items since we don't care if there is not item to update
+ if (!err.message?.endsWith("was not found")) {
+ throw err
+ }
+ })
 
  cart = await this.retrieve(cart.id, {
  relations: ["items", "discounts", "discounts.rule", "region"],
@@ -812,7 +817,12 @@ class CartService extends TransactionBaseService {
  },
  { has_shipping: false }
  )
- .catch(() => void 0)
+ .catch((err: Error) => {
+ // We only want to catch the errors related to not found items since we don't care if there is not item to update
+ if (!err.message?.endsWith("was not found")) {
+ throw err
+ }
+ })
 
  cart = await this.retrieve(cart.id, {
  relations: ["items", "discounts", "discounts.rule", "region"],