chore: safe catch by verifying the appropriate error

medusajs · Dec 7, 2022 · a00fe15 · a00fe15
1 parent 9062b8e
commit a00fe15
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/packages/medusa/src/services/cart.ts b/packages/medusa/src/services/cart.ts
@@ -667,7 +667,10 @@ class CartService extends TransactionBaseService {
  )
  .catch((err: Error) => {
  // We only want to catch the errors related to not found items since we don't care if there is not item to update
- if (!err.message?.endsWith("was not found")) {
+ if (
+ !(err instanceof MedusaError) ||
+ err.type !== MedusaError.Types.NOT_FOUND
+ ) {
  throw err
  }
  })
@@ -819,7 +822,10 @@ class CartService extends TransactionBaseService {
  )
  .catch((err: Error) => {
  // We only want to catch the errors related to not found items since we don't care if there is not item to update
- if (!err.message?.endsWith("was not found")) {
+ if (
+ !(err instanceof MedusaError) ||
+ err.type !== MedusaError.Types.NOT_FOUND
+ ) {
  throw err
  }
  })