Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Grammar/spelling issue on new account registration flow #9674

Closed
ShaunXenonKhan opened this issue Oct 18, 2024 · 1 comment
Closed

Comments

@ShaunXenonKhan
Copy link

ShaunXenonKhan commented Oct 18, 2024

Bug report

Describe the bug

I noticed two grammatical errors affecting the Medusa Admin's professionalism during the account creation flow.

  1. "Create you account below" should be "Create your account below"
  2. "Your account has is registered" should be "Your account has been registered" or "Your account is now registered"

System information

Medusa version (including plugins): 2.0.0-rc.7 without plugins (the issue was noticed in the preview and regrettably, I didn't raise the issue sooner)
Node.js version: n/a
Database: n/a
Operating system: n/a
Browser (if relevant): n/a

Steps to reproduce the behavior

  1. Invite a new user to create an admin account
  2. Follow link to account creation form
  3. See error

Source files

The source file is "packages/admin/dashboard/src/i18n/translations/en.json"

Here are the keys:

Issue 1: "invite.hint"
Issue 2: "invite.successTitle"

@ShaunXenonKhan ShaunXenonKhan changed the title Admin: Grammer/spelling issue on new account registration flow Admin: Grammar/spelling issue on new account registration flow Oct 18, 2024
@olivermrbl
Copy link
Contributor

@ShaunXenonKhan, thanks for the report. Please feel free to send a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants