Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(medusa): order retrieval missing relations + allow for expand #2267

Merged
merged 3 commits into from
Sep 29, 2022
Merged

fix(medusa): order retrieval missing relations + allow for expand #2267

merged 3 commits into from
Sep 29, 2022

Conversation

adrien2p
Copy link
Member

What

Fix missing relation on the order retrieval endpoint as well as allow the expand fields

FIXES CORE-578

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: e5a1544

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p force-pushed the fix/swap-missing-relations branch 3 times, most recently from d2cfc89 to f5ee664 Compare September 29, 2022 08:29
@adrien2p adrien2p marked this pull request as ready for review September 29, 2022 08:34
@adrien2p adrien2p requested a review from a team as a code owner September 29, 2022 08:34
srindom
srindom approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - have you verified that this solves the error thrown in Admin?

srindom
srindom approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - have you verified that this solves the error thrown in Admin?

@adrien2p
Copy link
Member Author

adrien2p commented Sep 29, 2022 •
edited
Loading

LGTM - have you verified that this solves the error thrown in Admin?

@kasperkristensen asked me to send the pr while he was revamping that area. It works and solve the issue.
Plus, the integration tests demonstrate that it works from an API point of view :)

@kodiakhq kodiakhq bot merged commit a2bb504 into develop Sep 29, 2022
@kodiakhq kodiakhq bot deleted the fix/swap-missing-relations branch September 29, 2022 10:04
@pKorsholm pKorsholm mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @srindom