fix(medusa) : Improperly referenced product id in product import strategy #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b2176be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@shahednasser Could you please review this pr . |
|
@ayushthe1 I only review documentation-related PRs. Please wait while someone from the engineering team gets the chance to review it 😊 |
Thanks .. sorry for bugging you 😅. |
ayushthe1
changed the title
olivermrbl
changed the title
fPolic
approved these changes
Oct 6, 2022
olivermrbl
reviewed
Oct 7, 2022
adrien2p
pushed a commit
that referenced
this pull request
Oct 11, 2022
…tegy (#2351) * What - fixing PR #2350 * Why - In the ProductImportStrategy class, the getImportInstructions improperly checks the product.id for each row. With it setup this way, products will always be considered new because the product.id column is not read here. So products will never be updated. [Link to the code line](https:/medusajs/medusa/blob/bd941309161bcee4fbfc7918d310c426ba8d8f15/packages/medusa/src/strategies/batch-jobs/product/import.ts#L166) * How - Replacing `row["product.product.id"]` to `row["product.id"]` Co-authored-by: Oliver Windall Juhl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What - fixing PR Improperly referenced product id when parsing CSV for bulk product update via import strategy #2350
Why - In the ProductImportStrategy class, the getImportInstructions improperly checks the product.id for each row. With it setup this way, products will always be considered new because the product.id column is not read here. So products will never be updated. Link to the code line
How - Replacing
row["product.product.id"]torow["product.id"]