Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(medusa): Add allowed relations to order retrieval #2370

Merged
merged 5 commits into from
Oct 6, 2022
Merged

fix(medusa): Add allowed relations to order retrieval #2370

merged 5 commits into from
Oct 6, 2022

Conversation

olivermrbl
Copy link
Contributor

What
Add allowed relations to list orders and get order to throw appropriate error message + status code

Test

  • Integration: Throw on invalid relation provided to list orders
  • Integration: Add test suite get order
    • Successfully retrieve order with expand + fields
    • Throw on invalid relation provided

@olivermrbl olivermrbl requested review from pKorsholm and a team October 6, 2022 11:58
@olivermrbl olivermrbl requested a review from a team as a code owner October 6, 2022 11:58
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: c3403c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

srindom
srindom approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 1c688ec into develop Oct 6, 2022
@kodiakhq kodiakhq bot deleted the fix/add-allowed-relations-to-order branch October 6, 2022 13:39
adrien2p pushed a commit that referenced this pull request Oct 11, 2022
@olivermrbl @adrien2p
fix(medusa): Add allowed relations to order retrieval (#2370)
05b91e7 
**What**
Add allowed relations to list orders and get order to throw appropriate error message + status code

**Test**
- Integration: Throw on invalid relation provided to list orders
- Integration: Add test suite get order
   - Successfully retrieve order with expand + fields
   - Throw on invalid relation provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@pKorsholm pKorsholm Awaiting requested review from pKorsholm

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivermrbl @srindom @carlos-r-l-rodrigues