Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): remove unused files from www directory #2722

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

patrick-medusajs
Copy link
Contributor

@patrick-medusajs patrick-medusajs commented Dec 2, 2022

What

Only keep /www/docs and remove all other files and directories from /www

Why

The www directory contained files that are not in use anymore. These dangling files lead to confusion when investigating usage of a specific piece of code.

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2022

⚠️ No Changeset found

Latest commit: 621a37c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@patrick-medusajs patrick-medusajs self-assigned this Dec 2, 2022
@patrick-medusajs patrick-medusajs marked this pull request as ready for review December 2, 2022 17:59
@patrick-medusajs patrick-medusajs requested a review from a team as a code owner December 2, 2022 17:59
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@shahednasser
Copy link
Member

Actually @patrick-medusajs can we change to the master branch? We use the master branch for basically everything docs and the required tests on the develop branch do not run for changes in the documentation directories

@patrick-medusajs patrick-medusajs changed the base branch from develop to master December 5, 2022 15:14
@patrick-medusajs patrick-medusajs requested a review from a team as a code owner December 5, 2022 15:14
@patrick-medusajs patrick-medusajs force-pushed the chore/remove-www-reference-directory branch from db84b86 to 621a37c Compare December 5, 2022 15:24
@patrick-medusajs
Copy link
Contributor Author

@shahednasser I rebased the branch onto master. Could you have a quick look to verify that I didn't mess anything. Then, I'll create a PR to merge master back into develop

@shahednasser
Copy link
Member

@patrick-medusajs all file changes look fine to me, and I testing running and building the current documentation - all works fine!

@patrick-medusajs patrick-medusajs merged commit 4cb93e3 into master Dec 5, 2022
@patrick-medusajs patrick-medusajs deleted the chore/remove-www-reference-directory branch December 5, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants