Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ✏️ Fix typo #2797

Closed
wants to merge 1 commit into from
Closed

docs: ✏️ Fix typo #2797

wants to merge 1 commit into from

Conversation

jhoffmann99
Copy link
Contributor

@jhoffmann99 jhoffmann99 commented Dec 14, 2022

What - Fix of typo in carts.ts
Why - A Documentation without typos is a better documentation :)
How - I've edited the corresponding file.
Testing - It's just a single character deletion.

@jhoffmann99 jhoffmann99 requested a review from a team as a code owner December 14, 2022 10:18
@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2022

⚠️ No Changeset found

Latest commit: 8891fde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jhoffmann99 thank you for making the change! I know I previously mentioned that you should open the PR to the master branch, but can you change it back to develop? 😅 Sorry we're facing some issues with the tests on the master branch. I'll close this PR for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants