Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(medusa): Typeorm upgrade to 0.3.11 #3041

Merged
merged 184 commits into from
Feb 15, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jan 16, 2023

What:

Upgrades to 0.3.11 version of typeorm from 0.2.**

Why:

Keeping our dependencies upto date and be able to utilize all the latest features typeorm has.

How:

0.3.* has a lot of breaking changes, we needed to identify these changes, use alternatives/build utils and create alternatives to broken/changed interfaces of a lot of typeorm methods.

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2023

🦋 Changeset detected

Latest commit: 8bebcc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@medusajs/medusa Minor
medusa-plugin-sendgrid Patch
medusa-payment-stripe Patch
medusa-plugin-algolia Patch
medusa-source-shopify Patch
medusa-core-utils Patch
medusa-file-minio Patch
medusa-interfaces Patch
medusa-test-utils Patch
@medusajs/stock-location Major
@medusajs/inventory Major
@medusajs/medusa-js Major
medusa-plugin-restock-notification Major
medusa-react Major
medusa-file-s3 Patch
medusa-file-spaces Patch
medusa-fulfillment-manual Patch
medusa-fulfillment-webshipper Patch
medusa-payment-adyen Patch
medusa-payment-klarna Patch
medusa-payment-manual Patch
medusa-payment-paypal Patch
medusa-plugin-brightpearl Patch
medusa-plugin-contentful Patch
medusa-plugin-discount-generator Patch
medusa-plugin-economic Patch
medusa-plugin-ip-lookup Patch
medusa-plugin-mailchimp Patch
medusa-plugin-meilisearch Patch
medusa-plugin-segment Patch
medusa-plugin-slack-notification Patch
medusa-plugin-twilio-sms Patch
medusa-plugin-wishlist Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gitguardian
Copy link

gitguardian bot commented Jan 16, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
5067995 Company Email Password 649f519 packages/medusa/src/services/tests/customer.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@riqwan riqwan changed the base branch from master to develop January 16, 2023 10:37
@riqwan riqwan force-pushed the feat/typeorm-upgrade-refactor branch from 7b4e480 to 27cb6f3 Compare January 17, 2023 07:50
@adrien2p
Copy link
Member

adrien2p commented Feb 6, 2023

integration-tests/api/factories/simple-cart-factory.ts

After investigation, my IDE had a hard wrap length set to 120 😂

@riqwan riqwan force-pushed the feat/typeorm-upgrade-refactor branch from 98135be to cebfb2b Compare February 7, 2023 09:20
@olivermrbl
Copy link
Contributor

olivermrbl commented Feb 14, 2023

Playing around in Medusa Admin spawned the following error when querying ProductVariants:

error:   Property "q" was not found in "ProductVariant". Make sure your query is correct.
EntityPropertyNotFoundError: Property "q" was not found in "ProductVariant". Make sure your query is correct

I was hitting endpoint "GET /admin/variants?q=&limit=12&offset=0

@olivermrbl
Copy link
Contributor

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: ef148cb

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, epic work! 🚢 🚤

@olivermrbl olivermrbl merged commit 121b42a into develop Feb 15, 2023
@riqwan riqwan deleted the feat/typeorm-upgrade-refactor branch February 20, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants