-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(medusa): Typeorm upgrade to 0.3.11 #3041
Conversation
🦋 Changeset detectedLatest commit: 8bebcc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
5067995 | Company Email Password | 649f519 | packages/medusa/src/services/tests/customer.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
7b4e480
to
27cb6f3
Compare
After investigation, my IDE had a hard wrap length set to 120 😂 |
b3fee28
to
98135be
Compare
98135be
to
cebfb2b
Compare
Playing around in Medusa Admin spawned the following error when querying ProductVariants:
I was hitting endpoint |
/snapshot-this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, epic work! 🚢 🚤
What:
Upgrades to 0.3.11 version of typeorm from 0.2.**
Why:
Keeping our dependencies upto date and be able to utilize all the latest features typeorm has.
How:
0.3.* has a lot of breaking changes, we needed to identify these changes, use alternatives/build utils and create alternatives to broken/changed interfaces of a lot of typeorm methods.