Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa-dev): include packages/ subdirectories in discovery #3293

Merged
merged 6 commits into from
Feb 21, 2023

Conversation

patrick-medusajs
Copy link
Contributor

What

Include packages/ subdirectories in medusa-dev packages discovery.

Why

We started to use subdirectories in the monorepo packages/ directory in order to better organize packages.

Packages in subdirectories were invisible to medusa-dev and could not be copied.

How

Rely on monorepo package.json workspace glob patterns to discover packages that can be published to the local npm registry.

- Rely on monorepo package.json workspace glob patterns to discover
  packages that can be published to the local npm registry.
@patrick-medusajs patrick-medusajs self-assigned this Feb 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2023

🦋 Changeset detected

Latest commit: 1ca05e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
medusa-dev-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@patrick-medusajs patrick-medusajs marked this pull request as ready for review February 20, 2023 20:01
@patrick-medusajs patrick-medusajs requested a review from a team as a code owner February 20, 2023 20:01
@kodiakhq kodiakhq bot merged commit e8e7d7b into develop Feb 21, 2023
@kodiakhq kodiakhq bot deleted the fix/medusa-dev-cli-workspace-subdirectories branch February 21, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants