Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): Only add ordering select if not already present #3319

Merged

Conversation

pKorsholm
Copy link
Contributor

What

  • fix bug where adding location_id as a queryparam for list-inventory-item would break list-inventory-item due to ambiguous reference

@pKorsholm pKorsholm requested a review from a team as a code owner February 22, 2023 18:15
@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2023

🦋 Changeset detected

Latest commit: ce3b79a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/inventory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl changed the title only add ordering select if not already selected fix(medusa): Only add ordering select if not already present Feb 26, 2023
@olivermrbl olivermrbl merged commit 08c8aa4 into develop Feb 26, 2023
@olivermrbl olivermrbl deleted the fix/location_id-in-list-inventory-item-query-params branch February 26, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants