fix(medusa): Clean response data usage for admin and store fields/expand #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 101076d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrien2p
commented
Feb 23, 2023
riqwan
reviewed
Feb 23, 2023
riqwan
reviewed
Feb 23, 2023
fPolic
reviewed
Feb 23, 2023
olivermrbl
approved these changes
Feb 27, 2023
olivermrbl
added
the
status: needs docs
|
@adrien2p Don't mind the label here. Added it to later find the PRs that need internal documentation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The clean response data utils was not properly or easy to use in the context of the admin domain. Cleanup and update the req API to include both
storeAllowedPropertiesandadminAllowedPropertiesto be used in the appropriate end point handler along side thecleanResponseData. As of now, the totals fields of any entities will remain present until the todo gets resolved. Otherwise it means that the user need to pass the total fields manually which in the end will trigger the legacy total computation instead of the performant oneRESOLVES CORE-1162