Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(modules-sdk,inventory,stock-location): modules isolated connection #3329

Merged
merged 57 commits into from
Mar 15, 2023
Merged

Feat(modules-sdk,inventory,stock-location): modules isolated connection #3329

merged 57 commits into from
Mar 15, 2023

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues commented Feb 23, 2023 •
edited
Loading

RESOLVES: CORE-1138, CORE-1139, CORE-1240

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 0d8e7a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@medusajs/stock-location Major
@medusajs/inventory Major
medusa-core-utils Minor
@medusajs/modules-sdk Minor
@medusajs/medusa Major
medusa-interfaces Major
@medusajs/admin Major
@medusajs/cache-inmemory Major
@medusajs/cache-redis Major
@medusajs/medusa-js Major
medusa-payment-stripe Major
medusa-plugin-restock-notification Major
medusa-react Major
medusa-file-minio Major
medusa-file-s3 Major
medusa-file-spaces Major
medusa-fulfillment-manual Major
medusa-fulfillment-webshipper Major
medusa-payment-adyen Major
medusa-payment-klarna Major
medusa-payment-manual Major
medusa-payment-paypal Major
medusa-plugin-algolia Major
medusa-plugin-brightpearl Major
medusa-plugin-contentful Major
medusa-plugin-discount-generator Major
medusa-plugin-economic Major
medusa-plugin-ip-lookup Major
medusa-plugin-mailchimp Major
medusa-plugin-meilisearch Major
medusa-plugin-segment Major
medusa-plugin-sendgrid Major
medusa-plugin-slack-notification Major
medusa-plugin-twilio-sms Major
medusa-plugin-wishlist Major
medusa-source-shopify Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@carlos-r-l-rodrigues carlos-r-l-rodrigues changed the base branch from master to develop February 23, 2023 19:54
@carlos-r-l-rodrigues carlos-r-l-rodrigues marked this pull request as ready for review February 24, 2023 11:10
@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner February 24, 2023 11:10
@medusajs medusajs deleted a comment from netlify bot Feb 24, 2023
@olivermrbl olivermrbl added the status: needs docs Needs internal documentation (as a minimum) label Feb 28, 2023
adrien2p
adrien2p requested changes Feb 28, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, great work man 💪

packages/inventory/src/loaders/container.ts Outdated Show resolved Hide resolved
packages/inventory/src/loaders/container.ts Outdated Show resolved Hide resolved
packages/medusa-core-utils/src/medusa-container.ts Show resolved Hide resolved
packages/medusa/src/commands/utils/get-migrations.js Outdated Show resolved Hide resolved
packages/medusa/src/loaders/__tests__/plugins.spec.ts Outdated Show resolved Hide resolved
packages/modules-sdk/src/loaders/utils/load-internal.ts Outdated Show resolved Hide resolved
packages/modules-sdk/src/loaders/utils/load-internal.ts Outdated Show resolved Hide resolved
packages/modules-sdk/src/loaders/utils/load-internal.ts Outdated Show resolved Hide resolved
packages/modules-sdk/src/loaders/utils/load-internal.ts Show resolved Hide resolved
packages/modules-sdk/src/types/index.ts Show resolved Hide resolved
@adrien2p
Copy link
Member

I suppose it will also evolved with the arriving of the factories right?

olivermrbl
olivermrbl reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @carlos-r-l-rodrigues! Only have a couple of comments. Also, can I get you to add a changeset? 🙏

packages/stock-location/src/migrations/index.ts Show resolved Hide resolved
packages/modules-sdk/src/loaders/utils/load-internal.ts Outdated Show resolved Hide resolved
packages/stock-location/src/loaders/connection.ts Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Mar 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 2:43PM (UTC)
staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 2:43PM (UTC)

@olivermrbl
Copy link
Contributor

@carlos-r-l-rodrigues Only missing a single failing test suite. Otherwise, we should be good to merge :)

@olivermrbl
Copy link
Contributor

@adrien2p should we make that thing turn green? 😄

adrien2p
adrien2p approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪 nice work man

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit 77d4622 into develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
status: needs docs Needs internal documentation (as a minimum) version: minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlos-r-l-rodrigues @adrien2p @olivermrbl