Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore admin-ui in core test pipeline #3381

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@olivermrbl olivermrbl requested a review from a team as a code owner March 5, 2023 15:19
@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2023

⚠️ No Changeset found

Latest commit: 43b5605

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 10:26AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
medusa-docs ⬜️ Ignored (Inspect) Mar 7, 2023 at 10:26AM (UTC)

Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperkristensen
Copy link
Contributor

@olivermrbl Why are we ignoring admin-ui? It needs to be build. The yarn build command only builds the API in /src, and is needed as @medusajs/admin uses this API when building the dashboard found in /ui.

@olivermrbl
Copy link
Contributor Author

@kasperkristensen I am ignoring it in the test workflows. Do we need to build it for those to pass? 🤔

@olivermrbl olivermrbl changed the title chore: Ignore admin-ui in core pipeline chore: Ignore admin-ui in core test pipeline Mar 6, 2023
@olivermrbl
Copy link
Contributor Author

Merging this now, as we will have many UI PRs being opened in the coming days.

@olivermrbl olivermrbl merged commit aadc1e1 into develop Mar 7, 2023
@olivermrbl olivermrbl deleted the chore/ignore-admin-in-pipeline branch March 7, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants