-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci,oas) move oas ci script to a package under the oas workspace #3391
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@medusajs/medusa": patch | ||
| --- | ||
|
|
||
| fix(ci,oas) move oas ci script to a package under the oas workspace |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,9 +20,6 @@ | |
| "@babel/preset-react": "^7.18.6", | ||
| "@babel/register": "^7.11.5", | ||
| "@babel/runtime": "^7.11.2", | ||
| "@medusajs/medusa-oas-cli": "*", | ||
| "@readme/openapi-parser": "^2.4.0", | ||
| "@redocly/cli": "1.0.0-beta.123", | ||
| "@typescript-eslint/eslint-plugin": "^5.53.0", | ||
| "@typescript-eslint/parser": "^5.53.0", | ||
| "axios": "^0.21.4", | ||
|
|
@@ -38,13 +35,11 @@ | |
| "eslint-plugin-react": "^7.31.11", | ||
| "eslint-plugin-react-hooks": "^4.6.0", | ||
| "eslint-plugin-unused-imports": "^2.0.0", | ||
| "execa": "^5.1.1", | ||
| "express": "^4.17.1", | ||
| "get-port": "^5.1.1", | ||
| "husky": "^7.0.4", | ||
| "import-from": "^3.0.0", | ||
| "jest": "^26.6.3", | ||
| "js-yaml": "^4.1.0", | ||
| "lint-staged": "^11.2.6", | ||
| "microbundle": "^0.13.3", | ||
| "pg-god": "^1.0.12", | ||
|
|
@@ -79,7 +74,7 @@ | |
| "test:integration:api": "turbo run test --no-daemon --filter=integration-tests-api", | ||
| "test:integration:plugins": "turbo run test --no-daemon --filter=integration-tests-plugins", | ||
| "test:integration:repositories": "turbo run test --no-daemon --filter=integration-tests-repositories", | ||
| "openapi:generate": "node ./scripts/build-openapi.js", | ||
| "openapi:generate": "yarn ./packages/oas/oas-github-ci run ci", | ||
| "generate:services": "typedoc --options typedoc.services.js", | ||
| "generate:js-client": "typedoc --options typedoc.js-client.js", | ||
| "generate:entities": "typedoc --options typedoc.entities.js", | ||
|
|
@@ -99,5 +94,9 @@ | |
| "global": "^4.4.0", | ||
| "import-from": "^3.0.0" | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| "packageManager": "[email protected]", | ||
| "resolutions": { | ||
| "@redocly/cli/react": "^17.0.1", | ||
| "@redocly/cli/react-dom": "^17.0.1" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| /dist | ||
| node_modules | ||
| .DS_store | ||
| .env* | ||
| .env | ||
| *.sql |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # @medusajs/oas-github-ci | ||
|
|
||
| ## 1.0.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # oas-github-ci - 1.0.0 | ||
|
|
||
| Script used in CI for validating OAS documentation. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "name": "@medusajs/oas-github-ci", | ||
| "version": "1.0.0", | ||
| "description": "OAS Github CI", | ||
| "main": "scripts/build-openapi.js", | ||
| "files": [ | ||
| "scripts" | ||
| ], | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https:/medusajs/medusa", | ||
| "directory": "packages/oas/oas-github-ci" | ||
| }, | ||
| "publishConfig": { | ||
| "access": "restricted" | ||
| }, | ||
| "author": "Medusa", | ||
| "license": "MIT", | ||
| "scripts": { | ||
| "ci": "node scripts/build-openapi.js", | ||
| "preview:admin": "yarn redocly preview-docs ../../../docs/api/admin/openapi.yaml --config=../../../docs-util/redocly/config.yaml", | ||
| "preview:store": "yarn redocly preview-docs ../../../docs/api/store/openapi.yaml --config=../../../docs-util/redocly/config.yaml", | ||
| "test": "jest --passWithNoTests", | ||
| "test:unit": "jest --passWithNoTests" | ||
| }, | ||
| "dependencies": { | ||
| "@medusajs/medusa-oas-cli": "*", | ||
| "@readme/openapi-parser": "^2.4.0", | ||
| "@redocly/cli": "1.0.0-beta.123", | ||
| "execa": "^5.1.1", | ||
| "js-yaml": "^4.1.0" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Is there a reason for making this restricted? This setting is blocking us from publishing it in our pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package is only relevant in our monorepo context. It doesn't provide any value as a standalone package. That's why I kept it as restricted. I don't think it needs to be published on npm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I think we'll have to change it to
private: true. Changeset does not recognize this config when running the script to publish packages. If okay with you, I'll open a PR with it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah jeez, my bad for using the wrong flag in the package.json. Thanks for the PR.