Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui, medusa-js, medusa-react, medusa): Multiwarehousing UI #3403

Merged
merged 33 commits into from
Mar 8, 2023

Conversation

StephixOne
Copy link
Contributor

@StephixOne StephixOne commented Mar 7, 2023

All remaining parts of Multiwarehousing Admin UI, alongside some small tweaks and additions needed in the API.

What
Major changes

  • Add inventory item tables and stocked_quantity editing for inventory item levels

    packages/admin-ui/ui/src/domain/inventory/**

  • Add allocation capabilities in the orders domain

    packages/admin-ui/ui/src/domain/orders/details/**

    • includes adding locations to fulfillments

      packages/admin-ui/ui/src/domain/orders/details/create-fulfillment/**

  • Add stock location management for variants

    packages/admin-ui/ui/src/domain/products/**

The changes in medusa-js and react are the changes from the previous get-variant pr

Minor changes

  • Add suffix to input fields
  • Add new icons
  • update modal header design to reflect figma

Fixes CORE-994, CORE-995, CORE-996, CORE-1195, CORE-1197

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023

🦋 Changeset detected

Latest commit: 144fb00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/admin-ui Patch
@medusajs/medusa Patch
@medusajs/inventory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 2:46PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
medusa-docs ⬜️ Ignored (Inspect) Mar 8, 2023 at 2:46PM (UTC)

@pKorsholm pKorsholm marked this pull request as ready for review March 7, 2023 12:28
@pKorsholm pKorsholm requested a review from a team as a code owner March 7, 2023 12:28
@StephixOne StephixOne changed the title feat: Multiwarehousing UI feat(admin-ui, medusa): Multiwarehousing UI Mar 7, 2023
@StephixOne StephixOne changed the title feat(admin-ui, medusa): Multiwarehousing UI feat(admin-ui, medusa-js, medusa-react): Multiwarehousing UI Mar 7, 2023
@StephixOne StephixOne changed the title feat(admin-ui, medusa-js, medusa-react): Multiwarehousing UI feat(admin-ui, medusa-js, medusa-react, medusa): Multiwarehousing UI Mar 7, 2023
@srindom
Copy link
Collaborator

srindom commented Mar 7, 2023

When I go to product detail page I get this
CleanShot 2023-03-07 at 3 45 12@2x

CleanShot 2023-03-07 at 3 45 33@2x

@srindom
Copy link
Collaborator

srindom commented Mar 7, 2023

Deleting or updating allocations doesn't work:

CleanShot 2023-03-07 at 3 46 21@2x

CleanShot 2023-03-07 at 3 47 22@2x

Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - I've added a couple of minor suggestions but LGTM!

.changeset/red-singers-swim.md Outdated Show resolved Hide resolved
)
}

const StockForm = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: we get an exception if the inventory module is not installed, should we have a fallback

@StephixOne
Copy link
Contributor Author

When I go to product detail page I get this CleanShot 2023-03-07 at 3 45 12@2x

CleanShot 2023-03-07 at 3 45 33@2x

@srindom Can you please re-check this after running migrations, as per Adrien's comment in #eng this morning.

@srindom
Copy link
Collaborator

srindom commented Mar 8, 2023

Can you please re-check this after running migrations, as per Adrien's comment in #eng this morning.

@StephixOne - great it works! 👍

@srindom
Copy link
Collaborator

srindom commented Mar 8, 2023

Should we merge this and start testing off of develop?

@pKorsholm
Copy link
Contributor

pKorsholm commented Mar 8, 2023

I think it's ready, just waiting for a final go from Rares to make sure he doesn't have any remaining changes 😄

@pKorsholm pKorsholm merged commit 57d7728 into develop Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants