Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(medusa, admin-ui): Order allocations #3419

Merged
merged 9 commits into from
Mar 9, 2023
Merged

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Mar 8, 2023

What

  • Fix delete-reservation endpoint to allow deletions of reservations
  • remove inventory_item_id from reservation update call to properly update reservation
  • invalidate all list caches to properly update order overview after an allocation has been created
  • Fix overlap for long product titles in edit-allocation-modal

Fixes CORE-1214

@pKorsholm pKorsholm requested a review from a team as a code owner March 8, 2023 16:32
@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
medusa-docs ⬜️ Ignored (Inspect) Mar 9, 2023 at 4:38PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: 1f413ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/medusa Patch
medusa-react Patch
@medusajs/admin-ui Patch
@medusajs/inventory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@srindom
Copy link
Collaborator

srindom commented Mar 8, 2023

When we update a reservation to 0, I think it would make sense to delete it instead of updating it. Unless you can think of a scenario where it makes sense to have a neutral reservation? I can't.

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - would like a second iteration on the design for long content and suggest that we delete the reservation if the reservation quantity is updated to 0. But other than those two tweaks LGTM!

@pKorsholm pKorsholm requested a review from srindom March 9, 2023 07:45
@srindom
Copy link
Collaborator

srindom commented Mar 9, 2023

When I delete an allocation I sometimes get two toasters in Admin:

CleanShot 2023-03-09 at 2 31 53@2x

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we are moving text overlap to a separate PR

@kodiakhq kodiakhq bot merged commit 80b95a2 into develop Mar 9, 2023
@kodiakhq kodiakhq bot deleted the fix/delete-reservation branch March 9, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants