Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): Fix fulfilment creation #3434

Merged
merged 6 commits into from
Mar 10, 2023
Merged

Conversation

StephixOne
Copy link
Contributor

@StephixOne StephixOne commented Mar 9, 2023

Errors object was getting nested, thus a check for "have there been any errors" looking at object keys would always hold true and stop creation and show a toast.

Resolves CORE-1223.

@StephixOne StephixOne requested a review from a team as a code owner March 9, 2023 16:14
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

🦋 Changeset detected

Latest commit: 0dbf039

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
medusa-docs ⬜️ Ignored (Inspect) Mar 10, 2023 at 1:21PM (UTC)

@srindom
Copy link
Collaborator

srindom commented Mar 9, 2023

I am still experiencing difficulties with this:

CleanShot.2023-03-09.at.5.49.39.mp4

@StephixOne
Copy link
Contributor Author

Hmm okay, let me investigate some more.

@srindom
Copy link
Collaborator

srindom commented Mar 9, 2023

It seems to work when I decrement and then increment again - maybe something with the defaults or a useEffect not being triggered?

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙏

@srindom srindom merged commit f43f03b into develop Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants