Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Show all locations in allocation creation modal #3448

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

StephixOne
Copy link
Contributor

@StephixOne StephixOne commented Mar 10, 2023

Removes constraint for location sales channel to match order sales channel in order to show that location in the allocation modal creation dropdown.

Also bundled a small update to the address form, changing the placeholder for the company field from "Medusa" to "Company".

Resolves CORE-1222, CORE-1188

@StephixOne StephixOne requested a review from a team as a code owner March 10, 2023 13:57
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

🦋 Changeset detected

Latest commit: 116979b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
medusa-docs ⬜️ Ignored (Inspect) Mar 10, 2023 at 2:11PM (UTC)

@StephixOne StephixOne changed the title fix(admin): Show all locations in allocation creation modal fix(admin-ui): Show all locations in allocation creation modal Mar 10, 2023
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - works like a charm 👍

@srindom srindom merged commit d4af873 into develop Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants