fix(admin-ui): Inventory and order UI fixes and tweaks #3461
Conversation
🦋 Changeset detectedLatest commit: 52912c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
LGTM! Great work.
@kasperkristensen - can you take a look at UI before merging :)
| close() | ||
| }, | ||
| onError: () => { | ||
| notification("Errors", "Failed to deleted ", "success") | ||
| notification("Errors", "Failed to delete the allocation ", "error") |
There was a problem hiding this comment.
very-nit(non-blocking): Should the title not be "Error" instead of "Errors", or even better a more descriptive title, like what you have done for the onSuccess.
There was a problem hiding this comment.
Fixed "Errors" to "Error", but as far as I can tell, the "Error" title is very much standard in our codebase so far, I don't know if I'd want to have just the one be more verbose.
There was a problem hiding this comment.
Let's revisit our error messages some other time and merge this now thanks! 👍
This PR aims to tackle a few different small fixes and tweaks related to inventory and order details UI, in connection to multiwarehousing features.
Resolves CORE-1229, CORE-1228, CORE-1227, CORE-1233, CORE-1230