feat(codegen,types): SetRelation on expanded types #3477
Conversation
- Alias for SetRequired with SetNonNullable
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2d4c252 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ? findPropInAllOf(nestedRelation.field, model, allModels) | ||
| : getPropertyByName(nestedRelation.field, model) | ||
| const prop = ["all-of", "any-of", "all-of"].includes(model.export) | ||
| ? findPropInAllOf(nestedRelation.field, model, allModels) |
There was a problem hiding this comment.
suggestion: this method might need a name change. Got nothing to do with AllOf alone anymore
There was a problem hiding this comment.
Also, all-of is duplicated
There was a problem hiding this comment.
Good catch 🎣. Fixed in 1759dbf
| ? findPropInAllOf(nestedRelation.field, model, allModels) | ||
| : getPropertyByName(nestedRelation.field, model) | ||
| const prop = ["all-of", "any-of", "all-of"].includes(model.export) | ||
| ? findPropInAllOf(nestedRelation.field, model, allModels) |
There was a problem hiding this comment.
Also, all-of is duplicated
| NestedRelation: ${JSON.stringify(nestedRelation, null, 2)} | ||
| Model: ${JSON.stringify(model.spec, null, 2)}`) | ||
| } | ||
| if (["all-of", "any-of", "all-of"].includes(prop.export)) { |
There was a problem hiding this comment.
todo: all-of duplicated
There was a problem hiding this comment.
Good catch 🎣. Fixed in 1759dbf
What
On expanded relations, mutate type using SetRelation, an alias for SetRequired with SetNonNullable.
Why
Simplifies implementation in client code.
How
Extra scope:
eagersub-categorization to x-expanded-relations to highlight relations that are loaded using TypeORM eager.