Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oas,js,react): use AdminExtendedStoresRes instead of AdminStoresRes #3478

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

patrick-medusajs
Copy link
Contributor

What

Declare and use AdminExtendedStoresRes for [get] /admin/store endpoint.

Why

Only [get] /admin/store returns ExtendedStoreDTO. Other /admin/store endpoints return Store.

How

  • Create new AdminExtendedStoresRes OAS schema
  • Update medusa-js
  • Update medusa-react

@patrick-medusajs patrick-medusajs self-assigned this Mar 15, 2023
@patrick-medusajs patrick-medusajs requested a review from a team as a code owner March 15, 2023 01:28
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

🦋 Changeset detected

Latest commit: 72cde2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@medusajs/client-types Patch
medusa-react Patch
@medusajs/medusa-js Patch
@medusajs/medusa Patch
@medusajs/inventory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 11:19AM (UTC)

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 6748877 into develop Mar 15, 2023
@kodiakhq kodiakhq bot deleted the feat/admin-extended-stores-res branch March 15, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants